fix(vpc_gw_dhcp): Properly set fields that should default to true #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Jan 26, 2022
remyleone
reviewed
Jan 26, 2022
remyleone
reviewed
Jan 26, 2022
Tuetuopay
force-pushed
the
fix-vpc-gw-dhcp-defaults
branch
2 times, most recently
from
dbf2c43 to
7fd2f68
Compare
Terraform will make sure that fields not present in the file will be set, so we never send nil to the api and get its defaults. Set the defaults ourselves to be consistent with the docs.
Monitob
previously approved these changes
Jan 27, 2022
Monitob
suggested changes
Jan 27, 2022
Monitob
approved these changes
Jan 27, 2022
remyleone
pushed a commit
to remyleone/terraform-provider-scaleway
that referenced
this pull request
Mar 28, 2022
remyleone
added
the
vpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform will make sure that fields not present in the file will be set, so we never send nil to the api and get its defaults. Set the defaults ourselves to be consistent with the docs.
Intended to fix #1059