feat(container): add resource containers as service #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Feb 22, 2022
remyleone
reviewed
Feb 23, 2022
Monitob
force-pushed
the
feat-add-resource-containers-as-service
branch
from
808ec68 to
d399a16
Compare
Monitob
force-pushed
the
feat-add-resource-containers-as-service
branch
3 times, most recently
from
fbee80d to
5f62ee8
Compare
7 tasks
remyleone
changed the title
Monitob
force-pushed
the
feat-add-resource-containers-as-service
branch
from
5f62ee8 to
d5adb0f
Compare
Monitob
force-pushed
the
feat-add-resource-containers-as-service
branch
5 times, most recently
from
2ecfb4b to
d33f475
Compare
remyleone
reviewed
Mar 15, 2022
Monitob
force-pushed
the
feat-add-resource-containers-as-service
branch
2 times, most recently
from
f9482e6 to
f32292f
Compare
remyleone
reviewed
Mar 21, 2022
remyleone
reviewed
Mar 21, 2022
|
|
||
| ## Memory and vCPUs configuration | ||
|
|
||
| The vCPU represents a portion or share of the underlying, physical CPU that is assigned to a particular virtual machine (VM). |
There was a problem hiding this comment.
How is this portion measured? What is the maximum vCPU possible in theory? Is it a gauge?
There was a problem hiding this comment.
The hypervisor uses a portion of the physical CPU computing resources and allocates it to a vCPU which is assigned to a specific Container. The maximum allowed is 1.12 vCPU.
| | 512 | 280m | | ||
| | 1024 | 560m | | ||
|
|
||
| **Note:** 560mCPU accounts roughly for half of one CPU power of a Scaleway General Purpose instance |
Co-authored-by: Rémy Léone <[email protected]>
Co-authored-by: Rémy Léone <[email protected]> Update scaleway/resource_container.go Co-authored-by: Rémy Léone <[email protected]> Update scaleway/resource_container.go Co-authored-by: Rémy Léone <[email protected]> Update scaleway/resource_container.go Co-authored-by: Rémy Léone <[email protected]> Update scaleway/resource_container.go Co-authored-by: Rémy Léone <[email protected]> Update scaleway/resource_container.go Co-authored-by: Rémy Léone <[email protected]> fix(containers): add documentation and enhance resource
Monitob
force-pushed
the
feat-add-resource-containers-as-service
branch
from
fa49b11 to
84ab3b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
=========================================
- Coverage 1.60% 1.55% -0.05%
=========================================
Files 91 93 +2
Lines 14660 15127 +467
=========================================
Hits 235 235
- Misses 14402 14869 +467
Partials 23 23
Continue to review full report at Codecov.
|
remyleone
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.