Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(domain): DNAME support and improve performance when using record ID #1113

Merged
merged 6 commits into from
Apr 19, 2022
Merged

feat(domain): DNAME support and improve performance when using record ID #1113

merged 6 commits into from
Apr 19, 2022

Conversation

jerjako
Copy link
Contributor

@jerjako jerjako commented Feb 25, 2022

No description provided.

@jerjako jerjako added the domain Domains issues, bugs and feature requests label Feb 25, 2022
@jerjako jerjako marked this pull request as ready for review April 19, 2022 08:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1113 (4acc040) into master (ca9691e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1113      +/-   ##
=========================================
- Coverage    1.51%   1.51%   -0.01%     
=========================================
  Files          96      96              
  Lines       15558   15559       +1     
=========================================
  Hits          235     235              
- Misses      15300   15301       +1     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/resource_domain_record.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9691e...4acc040. Read the comment docs.

@jerjako jerjako requested a review from remyleone April 19, 2022 08:57
@Monitob
Copy link
Contributor

Monitob commented Apr 19, 2022

@jerjako You should run the acceptance test on this

@Monitob Monitob merged commit 1b7e08c into master Apr 19, 2022
@Monitob Monitob deleted the feat_dname branch April 19, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monitob Monitob Monitob approved these changes

@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

Assignees
No one assigned
Labels
domain Domains issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerjako @codecov-commenter @Monitob @remyleone