Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): add data source lb-certificate #1153

Merged
merged 6 commits into from
Mar 30, 2022
Merged

feat(lb): add data source lb-certificate #1153

merged 6 commits into from
Mar 30, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Mar 25, 2022

No description provided.

@Monitob Monitob linked an issue Mar 25, 2022 that may be closed by this pull request
Load-balancer frontend support multiple certificate Ids #845
Closed
@Monitob Monitob marked this pull request as draft March 28, 2022 08:15
@Monitob Monitob force-pushed the feat-add-data-source-lb-certificate branch from b85d335 to 5b7644e Compare March 28, 2022 15:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #1153 (3fda14e) into master (0333377) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1153      +/-   ##
=========================================
- Coverage    1.59%   1.59%   -0.01%     
=========================================
  Files          91      92       +1     
  Lines       14694   14744      +50     
=========================================
  Hits          235     235              
- Misses      14436   14486      +50     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/data_source_lb_certificate.go 0.00% <0.00%> (ø)
scaleway/provider.go 18.38% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0333377...3fda14e. Read the comment docs.

@Monitob Monitob force-pushed the feat-add-data-source-lb-certificate branch from 8f56bcc to 37eabda Compare March 28, 2022 15:23
@Monitob Monitob marked this pull request as ready for review March 28, 2022 15:25
@Monitob Monitob self-assigned this Mar 28, 2022
@Monitob Monitob requested a review from remyleone March 28, 2022 15:31
@remyleone remyleone changed the title feat(lb-certificate): add data source lb-certificate feat(lb): add data source lb-certificate Mar 29, 2022
@Monitob Monitob merged commit bb20009 into scaleway:master Mar 30, 2022
@Monitob Monitob deleted the feat-add-data-source-lb-certificate branch March 30, 2022 15:51
@remyleone remyleone added the load-balancer Load-balancer issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load-balancer frontend support multiple certificate Ids
3 participants
@Monitob @codecov-commenter @remyleone