Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance): add support for handling empty security-groups tags #1206

Merged
merged 7 commits into from
Apr 14, 2022
Merged

fix(instance): add support for handling empty security-groups tags #1206

merged 7 commits into from
Apr 14, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Apr 12, 2022

No description provided.

@Monitob Monitob requested a review from remyleone April 12, 2022 16:12
@remyleone remyleone changed the title fix(security-groups): tags fix(instance): add support for handling empty security-groups tags Apr 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #1206 (e4544cc) into master (55dbcc5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1206      +/-   ##
=========================================
- Coverage    1.52%   1.52%   -0.01%     
=========================================
  Files          95      95              
  Lines       15418   15434      +16     
=========================================
  Hits          235     235              
- Misses      15160   15176      +16     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/resource_instance_placement_group.go 0.00% <0.00%> (ø)
scaleway/resource_instance_security_group.go 0.00% <0.00%> (ø)
scaleway/resource_instance_snapshot.go 0.00% <0.00%> (ø)
scaleway/resource_instance_volume.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55dbcc5...e4544cc. Read the comment docs.

@Monitob Monitob requested a review from remyleone April 13, 2022 12:58
remyleone
remyleone reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI required

remyleone
remyleone requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ci

@Monitob Monitob self-assigned this Apr 14, 2022
@Monitob Monitob requested a review from remyleone April 14, 2022 13:44
@remyleone remyleone merged commit c70f0b6 into scaleway:master Apr 14, 2022
@Monitob Monitob linked an issue Apr 14, 2022 that may be closed by this pull request
Instance security groups tags failing #1182
Closed
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instance security groups tags failing
3 participants
@Monitob @codecov-commenter @remyleone