Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(private-network): add wait process for private networks on instance #1210

Merged
merged 9 commits into from
Apr 14, 2022
Merged

feat(private-network): add wait process for private networks on instance #1210

merged 9 commits into from
Apr 14, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Apr 13, 2022

No description provided.

@Monitob Monitob requested a review from remyleone April 13, 2022 15:42
@Monitob Monitob marked this pull request as draft April 13, 2022 15:49
remyleone
remyleone reviewed Apr 13, 2022
View reviewed changes
@Monitob Monitob force-pushed the fix-instance-private-networks branch from 4cd8bfa to 8322076 Compare April 14, 2022 12:25
@Monitob Monitob force-pushed the fix-instance-private-networks branch from 8322076 to cbc51ab Compare April 14, 2022 12:27
@Monitob Monitob requested a review from remyleone April 14, 2022 12:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #1210 (0d9a4c8) into master (c70f0b6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1210      +/-   ##
=========================================
- Coverage    1.52%   1.51%   -0.01%     
=========================================
  Files          95      95              
  Lines       15434   15486      +52     
=========================================
  Hits          235     235              
- Misses      15176   15228      +52     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/helpers_instance.go 0.00% <0.00%> (ø)
scaleway/resource_instance_private_nic.go 0.00% <0.00%> (ø)
scaleway/resource_instance_server.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70f0b6...0d9a4c8. Read the comment docs.

@Monitob Monitob marked this pull request as ready for review April 14, 2022 12:53
@remyleone remyleone merged commit a49039c into scaleway:master Apr 14, 2022
@Monitob Monitob deleted the fix-instance-private-networks branch April 14, 2022 13:54
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Monitob @codecov-commenter @remyleone