Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(domain): add waiting process for dns zone and associated reverse test #1217

Merged
merged 6 commits into from
Apr 20, 2022
Merged

feat(domain): add waiting process for dns zone and associated reverse test #1217

merged 6 commits into from
Apr 20, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Apr 15, 2022

No description provided.

@Monitob Monitob self-assigned this Apr 15, 2022
@Monitob Monitob marked this pull request as draft April 15, 2022 16:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1217 (05eb5e6) into master (7708a19) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1217      +/-   ##
=========================================
- Coverage    1.51%   1.51%   -0.01%     
=========================================
  Files          97      97              
  Lines       15511   15547      +36     
=========================================
  Hits          235     235              
- Misses      15253   15289      +36     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/helpers.go 13.87% <0.00%> (-0.30%) ⬇️
scaleway/helpers_domain.go 0.00% <0.00%> (ø)
scaleway/resource_domain_record.go 0.00% <0.00%> (ø)
scaleway/resource_instance_ip.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7708a19...05eb5e6. Read the comment docs.

@Monitob Monitob force-pushed the feat-domain-add-wait-dns-zone-state branch from 0ae567c to b1a7db7 Compare April 19, 2022 14:53
@Monitob Monitob mentioned this pull request Apr 19, 2022
Closed
@Monitob Monitob marked this pull request as ready for review April 19, 2022 17:18
@Monitob Monitob requested a review from remyleone April 19, 2022 17:19
@Monitob Monitob changed the title feat(domain): add waiting process for dns zone feat(domain): add waiting process for dns zone and associated reverse test Apr 19, 2022
remyleone
remyleone reviewed Apr 20, 2022
View reviewed changes
@Monitob Monitob force-pushed the feat-domain-add-wait-dns-zone-state branch 2 times, most recently from e2063a1 to bd1f73a Compare April 20, 2022 14:31
remyleone
remyleone previously approved these changes Apr 20, 2022
View reviewed changes
@Monitob Monitob force-pushed the feat-domain-add-wait-dns-zone-state branch from 05eb5e6 to 761236b Compare April 20, 2022 15:11
@Monitob Monitob merged commit 7c5234c into scaleway:master Apr 20, 2022
@Monitob Monitob deleted the feat-domain-add-wait-dns-zone-state branch April 20, 2022 15:42
@remyleone remyleone linked an issue Apr 20, 2022 that may be closed by this pull request
Domain: support waiting stable state when add record #1214
Closed
@remyleone remyleone added the domain Domains issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
domain Domains issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Domain: support waiting stable state when add record
3 participants
@Monitob @codecov-commenter @remyleone