Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(domain-record): TXT record and helpers #1235

Merged
merged 10 commits into from
Apr 26, 2022
Merged

Fix(domain-record): TXT record and helpers #1235

merged 10 commits into from
Apr 26, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Apr 22, 2022

  • Fix schema domain record
  • Fix read method
  • Fix helpers on TXT record DATA
  • Fix setter ID for resource domain_record
  • Fix add missing attributes to update process

@Monitob Monitob requested review from jerjako and remyleone April 22, 2022 11:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022 •
edited
Loading

Codecov Report

Merging #1235 (9b914ec) into master (fa90a79) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1235      +/-   ##
=========================================
- Coverage    1.51%   1.50%   -0.01%     
=========================================
  Files          97      97              
  Lines       15540   15574      +34     
=========================================
  Hits          235     235              
- Misses      15282   15316      +34     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/helpers_domain.go 0.00% <0.00%> (ø)
scaleway/resource_domain_record.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa90a79...9b914ec. Read the comment docs.

@Monitob Monitob linked an issue Apr 22, 2022 that may be closed by this pull request
scaleway_domain_record - Error : Provider produced inconsistent result after apply #1204
Closed
remyleone
remyleone reviewed Apr 22, 2022
View reviewed changes
@Monitob Monitob self-assigned this Apr 22, 2022
@Monitob Monitob marked this pull request as draft April 22, 2022 15:15
@Monitob Monitob marked this pull request as ready for review April 22, 2022 15:38
@Monitob Monitob requested a review from remyleone April 22, 2022 15:38
@Monitob Monitob force-pushed the fix-domain-record-read-update branch from bf50d44 to fc1f38d Compare April 25, 2022 10:27
@Monitob Monitob requested a review from remyleone April 25, 2022 10:28
@Monitob Monitob added the domain Domains issues, bugs and feature requests label Apr 25, 2022
@remyleone remyleone merged commit d7bb4eb into scaleway:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerjako jerjako jerjako left review comments

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
domain Domains issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scaleway_domain_record - Error : Provider produced inconsistent result after apply
4 participants
@Monitob @codecov-commenter @remyleone @jerjako