Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pat-rules): check attributes on update process #1248

Merged
merged 7 commits into from
May 2, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Apr 28, 2022

No description provided.

@Monitob Monitob force-pushed the fix-pat-rules-update branch from 4712b1a to 04d51f0 Compare April 28, 2022 13:38
@Monitob Monitob force-pushed the fix-pat-rules-update branch from f710808 to 0ea8dd7 Compare April 28, 2022 14:00
@Monitob Monitob requested a review from remyleone April 28, 2022 14:01
@codecov-commenter
Copy link

Codecov Report

Merging #1248 (b1440fd) into master (a73ab00) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1248      +/-   ##
=========================================
- Coverage    1.47%   1.47%   -0.01%     
=========================================
  Files         100     100              
  Lines       15937   15962      +25     
=========================================
  Hits          235     235              
- Misses      15679   15704      +25     
  Partials       23      23              
Impacted Files Coverage Δ
scaleway/resource_vpc_public_gateway_pat_rule.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73ab00...b1440fd. Read the comment docs.

@Monitob Monitob linked an issue Apr 28, 2022 that may be closed by this pull request
@remyleone remyleone merged commit 26372fc into scaleway:master May 2, 2022
@Monitob Monitob deleted the fix-pat-rules-update branch May 16, 2022 08:47
@remyleone remyleone added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change Private IP Address in Created PAT Rule
3 participants