Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpc-gw): add support for SSH bastion #1255

Merged
merged 9 commits into from
May 20, 2022

Conversation

remyleone
Copy link
Member

@remyleone remyleone commented May 4, 2022

Waiting on the VPC team to add support for bastion related fields in the create request

@codecov-commenter
Copy link

Codecov Report

Merging #1255 (239bc73) into master (4215bc3) will increase coverage by 0.02%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
+ Coverage   69.88%   69.91%   +0.02%     
==========================================
  Files         102      102              
  Lines       16309    16330      +21     
==========================================
+ Hits        11398    11417      +19     
  Misses       3929     3929              
- Partials      982      984       +2     
Impacted Files Coverage Δ
scaleway/helpers_rdb.go 82.66% <ø> (+3.29%) ⬆️
scaleway/helpers.go 75.19% <40.00%> (-0.47%) ⬇️
scaleway/resource_vpc_public_gateway.go 74.46% <78.37%> (+0.39%) ⬆️
scaleway/resource_rdb_instance.go 71.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4215bc3...239bc73. Read the comment docs.

@remyleone remyleone marked this pull request as ready for review May 20, 2022 14:23
@remyleone remyleone merged commit cb300f2 into scaleway:master May 20, 2022
@remyleone remyleone deleted the ssh_bastion branch May 20, 2022 14:52
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@remyleone remyleone added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants