Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis): add redis acl #1256

Merged
merged 5 commits into from
May 4, 2022
Merged

feat(redis): add redis acl #1256

merged 5 commits into from
May 4, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented May 4, 2022 •
edited
Loading

Implements #1234

@Codelax Codelax marked this pull request as draft May 4, 2022 10:18
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022 •
edited
Loading

Codecov Report

Merging #1256 (0cdb20e) into master (0b1c208) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1256      +/-   ##
=========================================
- Coverage    1.47%   1.46%   -0.01%     
=========================================
  Files         100     100              
  Lines       15975   16053      +78     
=========================================
  Hits          235     235              
- Misses      15717   15795      +78     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/helpers_redis.go 0.00% <0.00%> (ø)
scaleway/resource_redis_cluster.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1c208...0cdb20e. Read the comment docs.

@Codelax Codelax marked this pull request as ready for review May 4, 2022 10:22
@Codelax Codelax linked an issue May 4, 2022 that may be closed by this pull request
Add support for ACL in redis cluster #1234
Closed
remyleone
remyleone reviewed May 4, 2022
View reviewed changes
Copy link
Member

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the documentation?

@Codelax
Copy link
Member Author

Codelax commented May 4, 2022 •
edited
Loading

Could you also update the documentation?

There is currently no documentation for redis resource

@Codelax Codelax requested a review from remyleone May 4, 2022 12:16
@Codelax Codelax marked this pull request as draft May 4, 2022 12:20
@Codelax Codelax marked this pull request as ready for review May 4, 2022 12:45
@remyleone remyleone merged commit 58d0db9 into scaleway:master May 4, 2022
@remyleone remyleone added the redis Managed Redis issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
redis Managed Redis issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ACL in redis cluster
3 participants
@Codelax @codecov-commenter @remyleone