Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lb): check private network status #1259

Merged
merged 7 commits into from
May 5, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented May 4, 2022

@Monitob Monitob self-assigned this May 4, 2022
@Monitob Monitob added this to the v2.2.1 milestone May 4, 2022
@Monitob Monitob added the load-balancer Load-balancer issues, bugs and feature requests label May 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #1259 (b113364) into master (5bba67b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1259      +/-   ##
=========================================
- Coverage    1.44%   1.44%   -0.01%     
=========================================
  Files         102     102              
  Lines       16220   16250      +30     
=========================================
  Hits          235     235              
- Misses      15962   15992      +30     
  Partials       23      23              
Impacted Files Coverage Δ
scaleway/helpers_lb.go 6.59% <0.00%> (-0.45%) ⬇️
scaleway/resource_lb.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bba67b...b113364. Read the comment docs.

@Monitob Monitob requested a review from remyleone May 4, 2022 14:42
@Monitob Monitob merged commit 03fdc67 into scaleway:master May 5, 2022
@Monitob Monitob deleted the fix-lb-private-network-state branch May 5, 2022 14:47
remyleone pushed a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants