Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rdb-acl): set information on schema #1270

Merged
merged 8 commits into from
May 16, 2022
Merged

fix(rdb-acl): set information on schema #1270

merged 8 commits into from
May 16, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented May 11, 2022

No description provided.

@Monitob Monitob marked this pull request as draft May 11, 2022 12:41
@Monitob Monitob mentioned this pull request May 11, 2022
Merged
@Monitob Monitob changed the title bump: go tools and add coverage config with cassettes fix: rdb acl set information May 11, 2022
@Monitob Monitob force-pushed the feat-add-conver-test-rdb-acl branch from 15713fb to 12d6bbc Compare May 13, 2022 13:57
@Monitob Monitob marked this pull request as ready for review May 13, 2022 14:00
@Monitob Monitob self-assigned this May 13, 2022
@Monitob Monitob requested a review from remyleone May 13, 2022 14:00
@Monitob Monitob changed the title fix: rdb acl set information fix(rdb-acl): set information on schema May 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022 •
edited
Loading

Codecov Report

Merging #1270 (875f1eb) into master (b496953) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1270      +/-   ##
=========================================
- Coverage    1.44%   1.44%   -0.01%     
=========================================
  Files         102     102              
  Lines       16271   16315      +44     
=========================================
  Hits          235     235              
- Misses      16013   16057      +44     
  Partials       23      23
Impacted Files Coverage Δ
scaleway/resource_rdb_acl.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b496953...875f1eb. Read the comment docs.

remyleone
remyleone reviewed May 13, 2022
View reviewed changes
@Monitob Monitob requested a review from remyleone May 16, 2022 14:05
@remyleone remyleone merged commit bd36f66 into scaleway:master May 16, 2022
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@Monitob @remyleone
fix(rdb-acl): set information on schema (scaleway#1270)
f3deae4 
Co-authored-by: Rémy Léone <[email protected]>
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Monitob Monitob

Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Monitob @codecov-commenter @remyleone