Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(lb): fix test case with multiple private networks #1281

Merged
merged 5 commits into from
May 18, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented May 18, 2022

No description provided.

@Monitob Monitob self-assigned this May 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1281 (1d91199) into master (674adda) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1281   +/-   ##
======================================
  Coverage    1.43%   1.43%           
======================================
  Files         102     102           
  Lines       16327   16327           
======================================
  Hits          235     235           
  Misses      16069   16069           
  Partials       23      23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674adda...1d91199. Read the comment docs.

@Monitob Monitob marked this pull request as draft May 18, 2022 09:54
@Monitob Monitob marked this pull request as ready for review May 18, 2022 10:00
@Monitob Monitob requested a review from remyleone May 18, 2022 10:02
@remyleone remyleone merged commit 8afb07b into scaleway:master May 18, 2022
@Monitob Monitob deleted the fix-lb-private-networks branch May 18, 2022 12:16
remyleone pushed a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@remyleone remyleone added the load-balancer Load-balancer issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants