-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scaleway_instance_snapshot): volume type unified #1300
Merged
remyleone
merged 7 commits into
scaleway:master
from
Monitob:feat-volume-type-unified-instance
Jul 18, 2022
Merged
feat(scaleway_instance_snapshot): volume type unified #1300
remyleone
merged 7 commits into
scaleway:master
from
Monitob:feat-volume-type-unified-instance
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 122 122
Lines 19508 19521 +13
=======================================
+ Hits 13014 13024 +10
- Misses 5357 5359 +2
- Partials 1137 1138 +1
Continue to review full report at Codecov.
|
5faa226
to
3a3298f
Compare
fix lint chore: add volumetype as a pointer feat(snapshot): update sdk with unknownVolumetype bump: scaleway-sdk-go
3a3298f
to
ddfcd9d
Compare
Codelax
requested changes
Jun 28, 2022
Codelax
previously approved these changes
Jul 13, 2022
remyleone
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.