Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scaleway_instance_snapshot): volume type unified #1300

Merged
merged 7 commits into from
Jul 18, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented May 24, 2022

No description provided.

@Monitob Monitob marked this pull request as draft May 24, 2022 21:01
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #1300 (90b8e8f) into master (d998d65) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files         122      122           
  Lines       19508    19521   +13     
=======================================
+ Hits        13014    13024   +10     
- Misses       5357     5359    +2     
- Partials     1137     1138    +1     
Impacted Files Coverage Δ
scaleway/resource_instance_snapshot.go 75.90% <100.00%> (+2.04%) ⬆️
scaleway/retryable_transport.go 70.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d998d65...90b8e8f. Read the comment docs.

@Monitob Monitob force-pushed the feat-volume-type-unified-instance branch 2 times, most recently from 5faa226 to 3a3298f Compare June 28, 2022 14:43
@Monitob Monitob changed the title feat(scaleway_instance_snapshot): volume type unified stg feat(scaleway_instance_snapshot): volume type unified Jun 28, 2022
Monitob added 2 commits June 28, 2022 16:44
fix lint

chore: add volumetype as a pointer

feat(snapshot): update sdk with unknownVolumetype

bump: scaleway-sdk-go
@Monitob Monitob force-pushed the feat-volume-type-unified-instance branch from 3a3298f to ddfcd9d Compare June 28, 2022 14:44
@Monitob Monitob marked this pull request as ready for review June 28, 2022 14:45
@Codelax Codelax self-assigned this Jul 13, 2022
@Codelax Codelax self-requested a review July 13, 2022 14:54
Codelax
Codelax previously approved these changes Jul 13, 2022
@Codelax Codelax self-requested a review July 13, 2022 14:54
@Codelax Codelax dismissed their stale review July 13, 2022 14:55

Will not approve PR I worked on

@Codelax Codelax marked this pull request as draft July 13, 2022 14:58
@Codelax Codelax marked this pull request as ready for review July 18, 2022 08:23
@remyleone remyleone merged commit 46ebe46 into scaleway:master Jul 18, 2022
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants