Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(rdb): add details for rdb instance settings option #1305

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 1, 2022

Fix #791

@codecov-commenter
Copy link

Codecov Report

Merging #1305 (18581af) into master (534d1d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1305   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files         102      102           
  Lines       16332    16332           
=======================================
  Hits        11414    11414           
  Misses       3934     3934           
  Partials      984      984           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534d1d2...18581af. Read the comment docs.

@Codelax
Copy link
Member Author

Codelax commented Jun 1, 2022

I could also add an example in documentation but options may be deprecated in the future and this is just an hcl map

resource scaleway_rdb_instance main {
  name = "test-rdb"
  node_type = "db-dev-s"
  disable_backup = true
  engine = "PostgreSQL-11"
  user_name = "my_initial_user"
  password = "thiZ_is_v&ry_s3cret"
  settings = {
    work_mem = "4"
    max_connections = "200"
    effective_cache_size = "1300"
    maintenance_work_mem = "150"
    max_parallel_workers = "2"
    max_parallel_workers_per_gather = "2"
  }
}

@remyleone remyleone merged commit c1cee74 into scaleway:master Jun 1, 2022
@Codelax Codelax deleted the rdb_instance_settings_doc branch June 1, 2022 13:33
remyleone pushed a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add documentation on settings field in rdb_instance
3 participants