Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): add destroy_registry field to container namespace #1321

Merged
merged 7 commits into from
Jun 7, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 6, 2022

Fix #1215
Add a new field to scaleway_container_namespace

resource scaleway_container_namespace main {
    name = "test-cr-ns-01"
    destroy_registry = true
}

It defaults to false and can be set to true to delete registry namespace after container namespace

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #1321 (5092fa9) into master (d4210a1) will decrease coverage by 0.02%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
- Coverage   70.15%   70.13%   -0.03%     
==========================================
  Files         102      102              
  Lines       16422    16445      +23     
==========================================
+ Hits        11521    11533      +12     
- Misses       3922     3929       +7     
- Partials      979      983       +4     
Impacted Files Coverage Δ
scaleway/resource_container_namespace.go 70.68% <62.96%> (-2.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4210a1...5092fa9. Read the comment docs.

@Codelax Codelax marked this pull request as draft June 6, 2022 14:37
@Codelax Codelax marked this pull request as ready for review June 6, 2022 14:50
@Codelax Codelax requested a review from remyleone June 7, 2022 13:30
@remyleone remyleone merged commit 93f5c03 into scaleway:master Jun 7, 2022
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@remyleone remyleone added the container Container issues, bugs and feature requests label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Container issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

destroy a scaleway_container_namespace
4 participants