Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(domain): domain basic2 test subdomain name collide with basic #1322

Merged
merged 7 commits into from
Jun 7, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 7, 2022

No description provided.

@Codelax Codelax changed the title fix(domain): domain basics tests subdmain collide fix(domain): domain basics tests subdomain collide Jun 7, 2022
@Codelax Codelax changed the title fix(domain): domain basics tests subdomain collide fix(domain): domain basic2 test subdomain name collide with basic Jun 7, 2022
@Codelax Codelax marked this pull request as draft June 7, 2022 07:42
@codecov-commenter
Copy link

Codecov Report

Merging #1322 (6afc8e4) into master (8033c72) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
+ Coverage   69.96%   70.21%   +0.25%     
==========================================
  Files         102      102              
  Lines       16316    16428     +112     
==========================================
+ Hits        11415    11535     +120     
+ Misses       3922     3916       -6     
+ Partials      979      977       -2     
Impacted Files Coverage Δ
scaleway/resource_domain_record.go 84.55% <100.00%> (+0.94%) ⬆️
scaleway/resource_k8s_cluster.go 84.94% <0.00%> (+0.08%) ⬆️
scaleway/resource_k8s_pool.go 83.91% <0.00%> (+0.08%) ⬆️
scaleway/resource_instance_server.go 72.85% <0.00%> (+0.13%) ⬆️
scaleway/resource_lb_frontend.go 77.77% <0.00%> (+0.17%) ⬆️
scaleway/resource_rdb_instance.go 71.42% <0.00%> (+0.19%) ⬆️
scaleway/resource_lb_backend.go 76.29% <0.00%> (+0.19%) ⬆️
scaleway/resource_iot_routes.go 82.02% <0.00%> (+0.23%) ⬆️
scaleway/resource_redis_cluster.go 74.22% <0.00%> (+0.24%) ⬆️
scaleway/resource_instance_volume.go 74.88% <0.00%> (+0.34%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8033c72...6afc8e4. Read the comment docs.

@Codelax Codelax marked this pull request as ready for review June 7, 2022 13:27
@remyleone remyleone merged commit 3d6bf9c into scaleway:master Jun 7, 2022
@Codelax Codelax deleted the domain-nightly-fix branch June 7, 2022 14:48
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@remyleone remyleone added the domain Domains issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Domains issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants