Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container-cron): add new resource container cron #1329

Merged
merged 6 commits into from
Jun 28, 2022
Merged

feat(container-cron): add new resource container cron #1329

merged 6 commits into from
Jun 28, 2022

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Jun 14, 2022

No description provided.

@Monitob Monitob marked this pull request as draft June 14, 2022 15:01
@Monitob Monitob force-pushed the feat-containers-with-json-types branch from 4c8124a to 51ed2b3 Compare June 15, 2022 13:24
remyleone
remyleone reviewed Jun 16, 2022
View reviewed changes
remyleone
remyleone reviewed Jun 16, 2022
View reviewed changes
@Monitob Monitob force-pushed the feat-containers-with-json-types branch 2 times, most recently from 2fd2754 to 3b2f0b8 Compare June 24, 2022 14:24
@Monitob Monitob changed the title fix(type): JSONObject feat(container-cron): add new resource container cron Jun 27, 2022
@Monitob Monitob force-pushed the feat-containers-with-json-types branch from 4c8666c to d93a3d9 Compare June 27, 2022 16:37
@Monitob Monitob marked this pull request as ready for review June 27, 2022 16:51
@Monitob Monitob force-pushed the feat-containers-with-json-types branch from 85e9377 to 64383bd Compare June 28, 2022 10:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #1329 (d340d19) into master (3c553ab) will increase coverage by 0.09%.
The diff coverage is 66.96%.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   69.81%   69.90%   +0.09%     
==========================================
  Files         109      110       +1     
  Lines       17646    17809     +163     
==========================================
+ Hits        12319    12449     +130     
- Misses       4262     4278      +16     
- Partials     1065     1082      +17
Impacted Files Coverage Δ
scaleway/resource_container.go 61.09% <33.33%> (+3.15%) ⬆️
scaleway/resource_container_cron.go 66.66% <66.66%> (ø)
scaleway/helpers_container.go 65.42% <100.00%> (+11.09%) ⬆️
scaleway/provider.go 73.22% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c553ab...d340d19. Read the comment docs.

Codelax
Codelax previously approved these changes Jun 28, 2022
View reviewed changes
@Codelax Codelax self-requested a review June 28, 2022 11:52
@Monitob Monitob mentioned this pull request Jun 28, 2022
Closed
@Monitob Monitob merged commit 21dc4f5 into scaleway:master Jun 28, 2022
@Monitob Monitob deleted the feat-containers-with-json-types branch June 28, 2022 13:44
@remyleone remyleone added the container Container issues, bugs and feature requests label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

@Codelax Codelax Codelax approved these changes

Assignees
No one assigned
Labels
container Container issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Monitob @codecov-commenter @remyleone @Codelax