feat(iam): add iam application #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
- Coverage 70.26% 69.79% -0.48%
==========================================
Files 107 109 +2
Lines 17523 17646 +123
==========================================
+ Hits 12313 12316 +3
- Misses 4145 4264 +119
- Partials 1065 1066 +1
Continue to review full report at Codecov.
|
remyleone
reviewed
Jun 23, 2022
kindermoumoute
requested changes
Jun 23, 2022
| import iam "github.com/scaleway/scaleway-sdk-go/api/iam/v1alpha1" | ||
|
|
||
| // instanceAPIWithZone returns a new iam API for a Create request | ||
| func iamAPI(m interface{}) *iam.API { |
There was a problem hiding this comment.
Nit: when you switch to go1.18 this function can use generics
Monitob
suggested changes
Jun 24, 2022
Monitob
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.