Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): add iam ssh key resource #1340

Merged
merged 7 commits into from
Jul 7, 2022
Merged

feat(iam): add iam ssh key resource #1340

merged 7 commits into from
Jul 7, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jun 23, 2022

No description provided.

remyleone
remyleone requested changes Jun 23, 2022
View reviewed changes
@yfodil yfodil force-pushed the feat/iam_ssh_key branch from d51e22e to 80a505a Compare June 24, 2022 15:23
@yfodil yfodil marked this pull request as draft June 24, 2022 15:24
@yfodil yfodil force-pushed the feat/iam_ssh_key branch from a041530 to e820c4c Compare June 29, 2022 12:55
@yfodil yfodil marked this pull request as ready for review June 29, 2022 13:02
Monitob
Monitob previously requested changes Jul 1, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #1340 (e999b5f) into master (4bfd7e9) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   68.79%   68.16%   -0.63%     
==========================================
  Files         113      115       +2     
  Lines       18110    18280     +170     
==========================================
+ Hits        12458    12461       +3     
- Misses       4569     4737     +168     
+ Partials     1083     1082       -1
Impacted Files Coverage Δ
scaleway/data_source_iam_ssh_key.go 0.00% <0.00%> (ø)
scaleway/provider.go 71.53% <0.00%> (-0.56%) ⬇️
scaleway/resource_iam_ssh_key.go 0.00% <0.00%> (ø)
scaleway/retryable_transport.go 80.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfd7e9...e999b5f. Read the comment docs.

@remyleone remyleone dismissed Monitob’s stale review July 7, 2022 08:45

All fixed now :)

@remyleone remyleone merged commit 2e52e90 into master Jul 7, 2022
@remyleone remyleone deleted the feat/iam_ssh_key branch July 7, 2022 08:45
Mia-Cross pushed a commit to Mia-Cross/terraform-provider-scaleway that referenced this pull request Jul 7, 2022
@yfodil @remyleone @Mia-Cross
feat(iam): add iam ssh key resource (scaleway#1340)
f23025e 
Co-authored-by: Rémy Léone <[email protected]>
@remyleone remyleone added the iam IAM issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codelax Codelax Codelax left review comments

@remyleone remyleone remyleone approved these changes

@Monitob Monitob Monitob left review comments

Assignees
No one assigned
Labels
iam IAM issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yfodil @codecov-commenter @remyleone @Monitob @Codelax