Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): add iam api key resource #1343

Merged
merged 15 commits into from
Jul 7, 2022
Merged

feat(iam): add iam api key resource #1343

merged 15 commits into from
Jul 7, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jun 27, 2022 •
edited
Loading

No description provided.

@yfodil yfodil marked this pull request as draft June 27, 2022 16:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #1343 (9c70a07) into master (b367b47) will decrease coverage by 0.56%.
The diff coverage is 0.00%.

❗ Current head 9c70a07 differs from pull request most recent head ccf35a3. Consider uploading reports for the commit ccf35a3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   69.35%   68.79%   -0.57%     
==========================================
  Files         112      113       +1     
  Lines       17962    18110     +148     
==========================================
  Hits        12458    12458              
- Misses       4421     4569     +148     
  Partials     1083     1083
Impacted Files Coverage Δ
scaleway/provider.go 72.09% <0.00%> (-0.29%) ⬇️
scaleway/resource_iam_api_key.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b367b47...ccf35a3. Read the comment docs.

@yfodil yfodil marked this pull request as ready for review June 29, 2022 12:29
remyleone
remyleone reviewed Jul 4, 2022
View reviewed changes
@remyleone remyleone merged commit 4bfd7e9 into master Jul 7, 2022
@remyleone remyleone deleted the feat/iam_api_key branch July 7, 2022 08:32
Mia-Cross pushed a commit to Mia-Cross/terraform-provider-scaleway that referenced this pull request Jul 7, 2022
@yfodil @remyleone @Mia-Cross
feat(iam): add iam api key resource (scaleway#1343)
d76ff4c 
Co-authored-by: Rémy Léone <[email protected]>
@remyleone remyleone added the iam IAM issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
iam IAM issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yfodil @codecov-commenter @remyleone