Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): add iam policy resource #1344

Merged
merged 10 commits into from
Jul 7, 2022
Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 28, 2022

As this ressource needs an organization id, I added a mock one and replaced the one used in cassettes. This also assume there is a default project with the same id as the organization id one which should be the case. I'm open for alternative with the mocked organization id

@codecov-commenter
Copy link

Codecov Report

Merging #1344 (30a48e7) into master (4474c76) will decrease coverage by 1.37%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   69.81%   68.43%   -1.38%     
==========================================
  Files         109      113       +4     
  Lines       17646    18203     +557     
==========================================
+ Hits        12319    12457     +138     
- Misses       4262     4663     +401     
- Partials     1065     1083      +18     
Impacted Files Coverage Δ
scaleway/helpers_iam.go 0.00% <0.00%> (ø)
scaleway/provider.go 72.09% <0.00%> (-1.03%) ⬇️
scaleway/resource_iam_policy.go 0.00% <0.00%> (ø)
scaleway/validation.go 54.05% <0.00%> (-20.03%) ⬇️
scaleway/resource_vpc_public_gateway.go 74.03% <0.00%> (-0.08%) ⬇️
scaleway/data_source_iam_user.go 0.00% <0.00%> (ø)
scaleway/resource_container_cron.go 66.66% <0.00%> (ø)
scaleway/data_source_iam_application.go 0.00% <0.00%> (ø)
scaleway/resource_container.go 61.09% <0.00%> (+3.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4474c76...30a48e7. Read the comment docs.

@Codelax Codelax marked this pull request as ready for review July 6, 2022 15:06
@remyleone
Copy link
Member

Could you add documentation?

@remyleone remyleone merged commit 35b2997 into scaleway:master Jul 7, 2022
@Codelax Codelax deleted the iam_policy branch July 7, 2022 12:49
Mia-Cross pushed a commit to Mia-Cross/terraform-provider-scaleway that referenced this pull request Jul 7, 2022
@remyleone remyleone added the iam IAM issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iam IAM issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants