feat(account): add account project resource #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Jul 20, 2022
| }) | ||
| } | ||
|
|
||
| func TestAccScalewayAccountProject_NoUpdate(t *testing.T) { |
There was a problem hiding this comment.
What is the purpose of this test?
There was a problem hiding this comment.
This is a simple test with no update that we made on other resources, @Monitob asked for it
There was a problem hiding this comment.
What was the reason? When did such test broke? Terraform checks that redoing a read on a resource does not change the state 🤔
Codelax
requested changes
Jul 20, 2022
…raform-provider-scaleway into feat/account_project_resource
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
- Coverage 66.73% 66.38% -0.36%
==========================================
Files 122 123 +1
Lines 19521 19624 +103
==========================================
Hits 13027 13027
- Misses 5357 5460 +103
Partials 1137 1137
Continue to review full report at Codecov.
|
Codelax
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat #1051