Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway_network): add vpc gateway network data source #1383

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 21, 2022

Fix #1382

@codecov-commenter
Copy link

Codecov Report

Merging #1383 (79d9a43) into master (b9b8015) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
- Coverage   66.38%   66.36%   -0.02%     
==========================================
  Files         123      124       +1     
  Lines       19624    19679      +55     
==========================================
+ Hits        13027    13060      +33     
- Misses       5460     5480      +20     
- Partials     1137     1139       +2     
Impacted Files Coverage Δ
scaleway/data_source_vpc_gateway_network.go 59.25% <59.25%> (ø)
scaleway/provider.go 70.89% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b8015...79d9a43. Read the comment docs.

@Codelax Codelax marked this pull request as ready for review July 22, 2022 09:40
@Codelax Codelax merged commit 854d1af into scaleway:master Jul 22, 2022
@Codelax Codelax deleted the data_gateway_network branch July 22, 2022 15:51
@remyleone remyleone added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaleway_vpc_gateway_network data source
3 participants