Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return nil for nil strings ptr #1388

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 22, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #1388 (05efb6e) into master (f40f3c1) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   66.33%   66.31%   -0.03%     
==========================================
  Files         124      124              
  Lines       19714    19717       +3     
==========================================
- Hits        13078    13075       -3     
- Misses       5493     5497       +4     
- Partials     1143     1145       +2     
Impacted Files Coverage Δ
scaleway/helpers.go 73.00% <0.00%> (-0.52%) ⬇️
scaleway/retryable_transport.go 70.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40f3c1...05efb6e. Read the comment docs.

Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 28b5b4b into scaleway:master Jul 24, 2022
@Codelax Codelax deleted the strings_ptr_nil branch July 25, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants