Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): remove volume name when using image #1390

Merged
merged 8 commits into from
Jul 25, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 25, 2022

Fix #1384

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #1390 (5bc5903) into master (28b5b4b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1390      +/-   ##
==========================================
+ Coverage   66.32%   66.34%   +0.01%     
==========================================
  Files         124      124              
  Lines       19717    19727      +10     
==========================================
+ Hits        13078    13088      +10     
  Misses       5495     5495              
  Partials     1144     1144              
Impacted Files Coverage Δ
scaleway/resource_instance_server.go 73.38% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b5b4b...5bc5903. Read the comment docs.

@Codelax Codelax merged commit 090ddde into scaleway:master Jul 25, 2022
@Codelax Codelax deleted the instance_volume_name_fix branch July 25, 2022 10:34
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaleway instance does not boot correctly when deployed
4 participants