Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(account): deprecate resource account ssh key #1863

Merged
merged 5 commits into from
Apr 4, 2023
Merged

feat(account): deprecate resource account ssh key #1863

merged 5 commits into from
Apr 4, 2023

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Mar 30, 2023

No description provided.

@Monitob Monitob requested a review from remyleone March 30, 2023 13:57
@Monitob Monitob self-assigned this Mar 30, 2023
@Monitob Monitob added iam IAM issues, bugs and feature requests account Account issues, bugs and feature requests labels Mar 30, 2023
remyleone
remyleone requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI must pass

@Monitob Monitob requested a review from remyleone April 3, 2023 08:02
@Monitob Monitob force-pushed the feat-deprecate-resource-account-ssh-key branch from 7da6e4b to 8b5ceed Compare April 3, 2023 08:10
@Monitob Monitob force-pushed the feat-deprecate-resource-account-ssh-key branch from 1765567 to 74e94e8 Compare April 3, 2023 15:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023 •
edited
Loading

Codecov Report

Merging #1863 (1765567) into master (e688e0e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1765567 differs from pull request most recent head 74e94e8. Consider uploading reports for the commit 74e94e8 to get more accurate results

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
- Coverage   74.49%   74.47%   -0.02%     
==========================================
  Files         172      172              
  Lines       26901    26775     -126     
==========================================
- Hits        20041    19942      -99     
+ Misses       5165     5146      -19     
+ Partials     1695     1687       -8
Impacted Files Coverage Δ
scaleway/helpers_account.go 100.00% <ø> (ø)
scaleway/data_source_account_ssh_key.go 100.00% <100.00%> (+26.08%) ⬆️
scaleway/resource_account_ssh_key.go 100.00% <100.00%> (+18.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone added this pull request to the merge queue Apr 4, 2023
Merged via the queue into scaleway:master with commit dc8694f Apr 4, 2023
@Monitob Monitob deleted the feat-deprecate-resource-account-ssh-key branch April 4, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone

Assignees

@Monitob Monitob

Labels
account Account issues, bugs and feature requests iam IAM issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Monitob @codecov-commenter @remyleone