feat(cockpit): don't require token scopes #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantumsheep
added
enhancement
observability
remyleone
approved these changes
Apr 21, 2023
quantumsheep
pushed a commit
that referenced
this pull request
May 3, 2023
feat(mnq): add read and update queue sqs feat(mnq): sqs queues fix linter issues feat: add nats refactor: underscore unused function parameters docs: add documentation remove unused cassette remove code from another MR fix: ignore `time.Sleep` linter issue docs(mnq): fix sqs example namespace protocol fix: remove double error feat(mnq): set sqs specific url fix(mnq): if name_prefix is not set then it will never be feat(cockpit): don't require token scopes (#1905) feat(mnq): generate queue name feat(mnq): use NATS jetstream and improve tests refactor: replace `retryWhenAWSErrCodeEquals` by `retryOnAWSCode`
quantumsheep
added a commit
that referenced
this pull request
May 3, 2023
feat(mnq): add read and update queue sqs feat(mnq): sqs queues fix linter issues feat: add nats refactor: underscore unused function parameters docs: add documentation remove unused cassette remove code from another MR fix: ignore `time.Sleep` linter issue docs(mnq): fix sqs example namespace protocol fix: remove double error feat(mnq): set sqs specific url fix(mnq): if name_prefix is not set then it will never be feat(cockpit): don't require token scopes (#1905) feat(mnq): generate queue name feat(mnq): use NATS jetstream and improve tests refactor: replace `retryWhenAWSErrCodeEquals` by `retryOnAWSCode`
quantumsheep
added a commit
that referenced
this pull request
May 3, 2023
feat(mnq): add read and update queue sqs feat(mnq): sqs queues fix linter issues feat: add nats refactor: underscore unused function parameters docs: add documentation remove unused cassette remove code from another MR fix: ignore `time.Sleep` linter issue docs(mnq): fix sqs example namespace protocol fix: remove double error feat(mnq): set sqs specific url fix(mnq): if name_prefix is not set then it will never be feat(cockpit): don't require token scopes (#1905) feat(mnq): generate queue name feat(mnq): use NATS jetstream and improve tests refactor: replace `retryWhenAWSErrCodeEquals` by `retryOnAWSCode`
remyleone
pushed a commit
that referenced
this pull request
May 11, 2023
* feat(mnq): resource queue feat(mnq): add read and update queue sqs feat(mnq): sqs queues fix linter issues feat: add nats refactor: underscore unused function parameters docs: add documentation remove unused cassette remove code from another MR fix: ignore `time.Sleep` linter issue docs(mnq): fix sqs example namespace protocol fix: remove double error feat(mnq): set sqs specific url fix(mnq): if name_prefix is not set then it will never be feat(cockpit): don't require token scopes (#1905) feat(mnq): generate queue name feat(mnq): use NATS jetstream and improve tests refactor: replace `retryWhenAWSErrCodeEquals` by `retryOnAWSCode` * fix: typo * refactor: use fifo constant * fix: re-add deleted helpers * don't worry * compare raw bodies in matcher * fix linter issues * compare form bodies * fifo queue for nats * rename client * add custom endpoint attribute * forgot these * update documentation * fifo queue is sqs only (nats is always fifo) * document limitations * use classic list * fix logs * add descriptions * fix doc * use `logging.IsDebugOrHigher()` * add nats credentials in example queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.