Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mnq): fix nats credentials parsing #1990

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

quantumsheep
Copy link
Member

No description provided.

@quantumsheep quantumsheep added enhancement mnq Messaging and queuing issues, bugs and feature requests labels Jun 14, 2023
@quantumsheep quantumsheep self-assigned this Jun 14, 2023
remyleone
remyleone previously approved these changes Jun 15, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
quantumsheep Nathanael Demacon

Verified

This commit was signed with the committer’s verified signature. The key has expired.
quantumsheep Nathanael Demacon

Verified

This commit was signed with the committer’s verified signature. The key has expired.
quantumsheep Nathanael Demacon
@quantumsheep quantumsheep force-pushed the fix/mnq-queue-nats-credentials-parsing branch from a0641c0 to fdd7343 Compare June 15, 2023 09:47
@codecov-commenter
Copy link

Codecov Report

Merging #1990 (a0641c0) into master (a5f29dc) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

❗ Current head a0641c0 differs from pull request most recent head fdd7343. Consider uploading reports for the commit fdd7343 to get more accurate results

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   74.04%   73.83%   -0.21%     
==========================================
  Files         182      182              
  Lines       28655    28577      -78     
==========================================
- Hits        21217    21100     -117     
- Misses       5635     5673      +38     
- Partials     1803     1804       +1     
Impacted Files Coverage Δ
scaleway/helpers_mnq_queue.go 51.35% <0.00%> (-1.43%) ⬇️
scaleway/resource_vpc_private_network.go 57.70% <0.00%> (-20.34%) ⬇️

@remyleone remyleone added this pull request to the merge queue Jun 15, 2023
Merged via the queue into master with commit a7101e4 Jun 15, 2023
@remyleone remyleone deleted the fix/mnq-queue-nats-credentials-parsing branch June 15, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement mnq Messaging and queuing issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants