Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rdb): private network update from ipam service #2068

Merged
merged 8 commits into from
Jul 27, 2023

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Jul 25, 2023

close #2057

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #2068 (165222f) into master (35538bf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
+ Coverage   73.89%   73.90%   +0.01%     
==========================================
  Files         187      187              
  Lines       29527    29523       -4     
==========================================
+ Hits        21818    21820       +2     
+ Misses       5856     5851       -5     
+ Partials     1853     1852       -1     
Files Changed Coverage Δ
scaleway/resource_rdb_instance.go 71.97% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

@Monitob Monitob added this pull request to the merge queue Jul 27, 2023
Merged via the queue into scaleway:master with commit 534995a Jul 27, 2023
@Monitob Monitob deleted the fix-rdb-private-network-endpoint branch July 27, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify RDB private instance configuration transform it in public instance
3 participants