feat(iot_hub): add mqtt certificate attributes #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2368 +/- ##
=======================================
Coverage 73.77% 73.77%
=======================================
Files 229 229
Lines 35515 35559 +44
=======================================
+ Hits 26200 26233 +33
- Misses 7064 7073 +9
- Partials 2251 2253 +2 ☔ View full report in Codecov by Sentry. |
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
5 times, most recently
from
e5bcf8f to
0242d71
Compare
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
2 times, most recently
from
a9e7e15 to
7ea6460
Compare
remyleone
reviewed
Jan 18, 2024
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
3 times, most recently
from
681d47b to
a881587
Compare
Codelax
reviewed
Jan 19, 2024
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
3 times, most recently
from
633e1f4 to
6688d92
Compare
Codelax
reviewed
Jan 19, 2024
Codelax
reviewed
Jan 19, 2024
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
2 times, most recently
from
3284792 to
43d88e9
Compare
Codelax
changed the title
Codelax
reviewed
Jan 24, 2024
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
from
43d88e9 to
70efaa0
Compare
Codelax
reviewed
Feb 5, 2024
scaleway/resource_iot_hub.go
Outdated
| _ = diag.Diagnostic{ | ||
| Severity: diag.Warning, | ||
| AttributePath: cty.GetAttrPath("mqtt_ca"), | ||
| Summary: err.Error(), |
There was a problem hiding this comment.
Diagnostic allows a Summary and details.
Summary could be used to summarize the issue (ex: Failed to fetch io hub mqtt certificate).
And details can contain the real error that may be an error from go http client.
Laure-di
force-pushed
the
feat/provide_iot_mqtt_ca
branch
from
70efaa0 to
79eb69c
Compare
remyleone
reviewed
Feb 7, 2024
remyleone
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2264