Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipam): add support for ip reverse dns #2377

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jan 25, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Jan 25, 2024
@yfodil yfodil self-assigned this Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (59ca567) 73.72% compared to head (9f6fe58) 73.71%.

Files Patch % Lines
scaleway/resource_ipam_ip_reverse_dns.go 61.24% 42 Missing and 8 partials ⚠️
scaleway/helpers_ipam.go 21.42% 10 Missing and 1 partial ⚠️
scaleway/helpers_vpcgw.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
- Coverage   73.72%   73.71%   -0.02%     
==========================================
  Files         228      229       +1     
  Lines       35282    35436     +154     
==========================================
+ Hits        26013    26121     +108     
- Misses       7027     7064      +37     
- Partials     2242     2251       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil marked this pull request as ready for review January 26, 2024 09:52
@yfodil yfodil linked an issue Jan 26, 2024 that may be closed by this pull request
@remyleone remyleone added this pull request to the merge queue Jan 26, 2024
Merged via the queue into scaleway:master with commit 48ac8d5 Jan 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for ipam ip reverse dns
3 participants