Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lb): add support for tags in LB IPs #2564

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented May 7, 2024

No description provided.

@yfodil yfodil added enhancement load-balancer Load-balancer issues, bugs and feature requests labels May 7, 2024
@yfodil yfodil self-assigned this May 7, 2024
@remyleone remyleone added the priority:high New features label Jun 4, 2024
@yfodil yfodil marked this pull request as ready for review July 8, 2024 08:36
@yfodil yfodil requested a review from remyleone as a code owner July 8, 2024 08:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.02%. Comparing base (fe86049) to head (dd752d2).
Report is 118 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
- Coverage   71.43%   71.02%   -0.42%     
==========================================
  Files         277      334      +57     
  Lines       35875    33448    -2427     
==========================================
- Hits        25628    23755    -1873     
+ Misses       8028     7387     -641     
- Partials     2219     2306      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Jul 8, 2024
Merged via the queue into scaleway:master with commit 45cddcd Jul 8, 2024
42 checks passed
jremy42 pushed a commit that referenced this pull request Aug 1, 2024
* bump sdk go

* support tags in lb ips

* add doc

* update cassettes

* decouple test

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement load-balancer Load-balancer issues, bugs and feature requests priority:high New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants