Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deprecated dns_zone field #2633

Merged
merged 11 commits into from
Jun 27, 2024
Merged

fix: update deprecated dns_zone field #2633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2759a70
Fix: Update deprecated dns_zone field
jremy42 Jun 25, 2024
7b51c18
Fix: cassette ipam
jremy42 Jun 25, 2024
2791283
Fix: cassette tem
jremy42 Jun 25, 2024
a93fc2b
Fix: cassette vpcgw
jremy42 Jun 25, 2024
5c44bc0
Fix: cassette instance
jremy42 Jun 25, 2024
77d4587
Fix: cassette function
jremy42 Jun 25, 2024
8253fc8
Fix: cassette container
jremy42 Jun 26, 2024
0bb2b30
Fix: cassette instance
jremy42 Jun 26, 2024
9d842ee
Fix: cassette instance reverse dns
jremy42 Jun 26, 2024
f8bc0cf
Fix: cassette domain basix
jremy42 Jun 26, 2024
c5f97d6
Merge branch 'master' into fix/update-deprecated-dns-zone
jremy42 Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,935 changes: 2,462 additions & 3,473 deletions internal/services/container/testdata/domain-basic.cassette.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion internal/services/domain/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ func resourceDomainRecordRead(ctx context.Context, d *schema.ResourceData, m int
return nil
}

dnsZones, err := domainAPI.ListDNSZones(&domain.ListDNSZonesRequest{DNSZone: scw.StringPtr(dnsZone)}, scw.WithAllPages(), scw.WithContext(ctx))
dnsZones, err := domainAPI.ListDNSZones(&domain.ListDNSZonesRequest{DNSZones: []string{dnsZone}}, scw.WithAllPages(), scw.WithContext(ctx))
if err != nil {
if httperrors.Is404(err) || httperrors.Is403(err) {
d.SetId("")
Expand Down
Loading
Loading