Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instance_server): use instance_block helpers #2636

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 27, 2024

No description provided.

@Codelax Codelax added the instance Instance issues, bugs and feature requests label Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 86.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.06%. Comparing base (fe86049) to head (1021059).
Report is 106 commits behind head on master.

Files Patch % Lines
internal/types/map.go 0.00% 6 Missing ⚠️
internal/services/instance/helpers_instance.go 96.55% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2636      +/-   ##
==========================================
- Coverage   71.43%   71.06%   -0.37%     
==========================================
  Files         277      333      +56     
  Lines       35875    33370    -2505     
==========================================
- Hits        25628    23716    -1912     
+ Misses       8028     7342     -686     
- Partials     2219     2312      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review June 27, 2024 13:57
@Codelax Codelax requested a review from remyleone as a code owner June 27, 2024 13:57
@remyleone remyleone added this pull request to the merge queue Jun 27, 2024
Merged via the queue into scaleway:master with commit 977d9bc Jun 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants