feat(instance_server): support sbs_volume as root volume #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelax
added
enhancement
instance
Codelax
force-pushed
the
feat/instance-server-root-volume-sbs
branch
from
75856ad to
c2b0a44
Compare
Codelax
force-pushed
the
feat/instance-server-root-volume-sbs
branch
from
24a18a0 to
a38920a
Compare
github-actions
bot
added
load-balancer
Codelax
force-pushed
the
feat/instance-server-root-volume-sbs
branch
from
5376b1e to
04cdc94
Compare
github-actions
bot
added
the
vpc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
- Coverage 71.43% 71.07% -0.37%
==========================================
Files 277 337 +60
Lines 35875 34101 -1774
==========================================
- Hits 25628 24236 -1392
+ Misses 8028 7514 -514
- Partials 2219 2351 +132 ☔ View full report in Codecov by Sentry. |
remyleone
reviewed
Sep 17, 2024
| resource "scaleway_instance_server" "server" { | ||
| type = "PLAY2-MICRO" | ||
| image = "ubuntu_jammy" | ||
| root_volume { |
There was a problem hiding this comment.
How is it possible to find this volume from a data source? Does it have a name/id ?
There was a problem hiding this comment.
This creates a new volume, why would we use a data source ?
remyleone
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.