Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam_api_key): add data source #2647

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat(iam_api_key): add data source #2647

merged 4 commits into from
Jul 8, 2024

Conversation

tbellavia
Copy link
Contributor

Closes #2286

@tbellavia tbellavia added enhancement iam IAM issues, bugs and feature requests labels Jul 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (fe86049) to head (ba7b106).
Report is 116 commits behind head on master.

Files Patch % Lines
internal/services/iam/api_key_data_source.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
- Coverage   71.43%   70.97%   -0.46%     
==========================================
  Files         277      334      +57     
  Lines       35875    33399    -2476     
==========================================
- Hits        25628    23706    -1922     
+ Misses       8028     7387     -641     
- Partials     2219     2306      +87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax changed the title Feat/iam api key data source feat(iam_api_key): add data source Jul 3, 2024
@tbellavia tbellavia requested a review from yfodil as a code owner July 4, 2024 08:24
@remyleone remyleone force-pushed the feat/iam-api-key-data-source branch from 3335492 to ba7b106 Compare July 8, 2024 07:52
@remyleone remyleone enabled auto-merge July 8, 2024 07:57
@remyleone remyleone added this pull request to the merge queue Jul 8, 2024
Merged via the queue into scaleway:master with commit ed3c182 Jul 8, 2024
42 checks passed
jremy42 pushed a commit that referenced this pull request Aug 1, 2024
@tbellavia @remyleone @jremy42
feat(iam_api_key): add data source (#2647)
0ca3906 
* feat(iam): add iam api key datasource

* fix: golangci-lint errors

* docs(iam): add documentation for IAM api key datasource

---------

Co-authored-by: Rémy Léone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@Codelax Codelax Awaiting requested review from Codelax

@yfodil yfodil Awaiting requested review from yfodil

Assignees
No one assigned
Labels
enhancement iam IAM issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datasource iam_api_key
3 participants
@tbellavia @codecov-commenter @remyleone