Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverless): add sandbox field #2657

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 9, 2024

Closes #2656

@Codelax Codelax added enhancement container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests labels Jul 9, 2024
@Codelax Codelax self-assigned this Jul 9, 2024
@Codelax Codelax marked this pull request as ready for review July 9, 2024 12:24
@Codelax Codelax requested a review from remyleone as a code owner July 9, 2024 12:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.03%. Comparing base (fe86049) to head (18a1e40).
Report is 119 commits behind head on master.

Files Patch % Lines
internal/services/container/helpers_container.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
- Coverage   71.43%   71.03%   -0.41%     
==========================================
  Files         277      334      +57     
  Lines       35875    33472    -2403     
==========================================
- Hits        25628    23777    -1851     
+ Misses       8028     7388     -640     
- Partials     2219     2307      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone enabled auto-merge July 11, 2024 06:42
@remyleone remyleone added this pull request to the merge queue Jul 11, 2024
Merged via the queue into scaleway:master with commit 4138acf Jul 11, 2024
41 of 42 checks passed
jremy42 pushed a commit that referenced this pull request Aug 1, 2024
* feat(container): add sandbox field

* feat(function): add sandbox field

* add cassettes

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Container issues, bugs and feature requests enhancement function Serverless function issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(serverless): Add sandbox to Functions and Containers
3 participants