Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(iam): document using expires_at with time_rotating #2677

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Aug 1, 2024

Hey there!

This PR adds a doc item for iam_api_key to show the use of the expires_at parameter in combination with time_rotating

Reasoning for Change:
In my opinion, it could be interesting to document the proper usage of the expires_at parameter for API keys, as it's not super clear.

Prefer Scaleway Documentation:
In that case, it's a pretty Terraform-specific use case. On the console, the API creation modal uses the "duration" of the key as opposed to the expires_at parameter.

Terraform Configuration Language Features:
It's not ideal indeed to use a resource from a default provider, but in that case, it's the most proper way to use expires_at.

Feel free to close this PR if you disagree with the change.

Have a great day 💜

@cyclimse cyclimse requested a review from remyleone as a code owner August 1, 2024 10:05
@cyclimse cyclimse self-assigned this Aug 1, 2024
@remyleone remyleone added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit 966fd21 Aug 1, 2024
45 checks passed
@remyleone remyleone deleted the docs/add-docs-on-iam-api-key-expires-at branch August 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants