Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): add protected field #2693

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 7, 2024

Closes #2623

@Codelax Codelax added enhancement priority:high New features secret Managed Secret Manager issues, bugs and feature requests labels Aug 7, 2024
@Codelax Codelax self-assigned this Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (fe86049) to head (af29347).
Report is 139 commits behind head on master.

Files Patch % Lines
internal/services/secret/helpers.go 45.83% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
- Coverage   71.43%   71.02%   -0.42%     
==========================================
  Files         277      334      +57     
  Lines       35875    33522    -2353     
==========================================
- Hits        25628    23808    -1820     
+ Misses       8028     7400     -628     
- Partials     2219     2314      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the feat/secret-protected branch from da9a2a6 to af29347 Compare August 7, 2024 13:15
@Codelax Codelax marked this pull request as ready for review August 7, 2024 13:53
@Codelax Codelax requested a review from remyleone as a code owner August 7, 2024 13:53
@remyleone remyleone added this pull request to the merge queue Aug 7, 2024
Merged via the queue into scaleway:master with commit bddd49f Aug 7, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:high New features secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for secret protection
3 participants