Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): add type field #2698

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 9, 2024

Closes #2687

@Codelax Codelax added enhancement secret Managed Secret Manager issues, bugs and feature requests labels Aug 9, 2024
@Codelax Codelax self-assigned this Aug 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.17%. Comparing base (fe86049) to head (03ae9de).
Report is 158 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
- Coverage   71.43%   71.17%   -0.26%     
==========================================
  Files         277      335      +58     
  Lines       35875    33730    -2145     
==========================================
- Hits        25628    24009    -1619     
+ Misses       8028     7392     -636     
- Partials     2219     2329     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review August 9, 2024 12:51
@Codelax Codelax requested a review from remyleone as a code owner August 9, 2024 12:51
yfodil
yfodil previously approved these changes Aug 9, 2024
@remyleone remyleone added this pull request to the merge queue Aug 26, 2024
Merged via the queue into scaleway:master with commit 591cf5b Aug 26, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaleway_secret: types
4 participants