Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret_version): datasource project_id argument #2701

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 13, 2024

Fix #2699

@Codelax Codelax added bug secret Managed Secret Manager issues, bugs and feature requests labels Aug 13, 2024
@Codelax Codelax self-assigned this Aug 13, 2024
@Codelax Codelax force-pushed the fix/secret-version-ds-project-id branch from 41935df to 51b7077 Compare August 13, 2024 09:27
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (fe86049) to head (51b7077).
Report is 143 commits behind head on master.

Files Patch % Lines
internal/services/secret/helpers.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2701      +/-   ##
==========================================
- Coverage   71.43%   71.07%   -0.37%     
==========================================
  Files         277      334      +57     
  Lines       35875    33591    -2284     
==========================================
- Hits        25628    23874    -1754     
+ Misses       8028     7396     -632     
- Partials     2219     2321     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Aug 13, 2024
Merged via the queue into scaleway:master with commit a7e77ec Aug 13, 2024
40 checks passed
@Codelax Codelax deleted the fix/secret-version-ds-project-id branch August 13, 2024 09:43
nerda-codes pushed a commit that referenced this pull request Aug 14, 2024
* fix(secret_version): datasource project_id argument

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret manager: multiple elements found with the name my-secret
3 participants