Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpc): add custom route resource #2702

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Aug 13, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Aug 13, 2024
@yfodil yfodil self-assigned this Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 62.73585% with 79 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (fe86049) to head (217c2f2).
Report is 176 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/vpc/route.go 76.77% 22 Missing and 14 partials ⚠️
internal/services/vpc/testfuncs/sweep.go 0.00% 28 Missing ⚠️
internal/services/vpc/helpers.go 50.00% 10 Missing and 3 partials ⚠️
internal/services/mnq/helpers_mnq_queue.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
- Coverage   71.43%   71.07%   -0.37%     
==========================================
  Files         277      337      +60     
  Lines       35875    34042    -1833     
==========================================
- Hits        25628    24196    -1432     
+ Misses       8028     7499     -529     
- Partials     2219     2347     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the mnq Messaging and queuing issues, bugs and feature requests label Sep 13, 2024
@yfodil yfodil marked this pull request as ready for review September 13, 2024 09:35
@remyleone remyleone added this pull request to the merge queue Sep 13, 2024
Merged via the queue into scaleway:master with commit ed1abf5 Sep 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement mnq Messaging and queuing issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants