Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(secret): fix datasource test config #2705

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 20, 2024

No description provided.

@Codelax Codelax added tests secret Managed Secret Manager issues, bugs and feature requests labels Aug 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.12%. Comparing base (fe86049) to head (52304cc).
Report is 152 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   71.43%   71.12%   -0.32%     
==========================================
  Files         277      335      +58     
  Lines       35875    33740    -2135     
==========================================
- Hits        25628    23998    -1630     
+ Misses       8028     7411     -617     
- Partials     2219     2331     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax changed the title tests(secret): fix datasource test config fix(secret): do not use default project id in secret datasource Aug 20, 2024
@Codelax Codelax changed the title fix(secret): do not use default project id in secret datasource tests(secret): fix datasource test config Aug 20, 2024
@Codelax Codelax force-pushed the tests/secret-ds-fix branch from a3f6887 to 52304cc Compare August 20, 2024 11:52
@remyleone remyleone added this pull request to the merge queue Aug 20, 2024
Merged via the queue into scaleway:master with commit b29d99a Aug 20, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
secret Managed Secret Manager issues, bugs and feature requests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants