Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for staticcheck #2717

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Conversation

remyleone
Copy link
Member

No description provided.

@github-actions github-actions bot added rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests instance Instance issues, bugs and feature requests object Object storage issues, bugs and feature requests domain Domains issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests account Account issues, bugs and feature requests container Container issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests iot IoT issues, bugs and feature requests function Serverless function issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests iam IAM issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests baremetal vpcgw labels Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 87.68810% with 90 lines in your changes missing coverage. Please review.

Project coverage is 71.11%. Comparing base (fe86049) to head (ab462eb).
Report is 158 commits behind head on master.

Files Patch % Lines
internal/verify/date.go 0.00% 26 Missing ⚠️
internal/verify/cron.go 0.00% 15 Missing ⚠️
internal/verify/email.go 65.62% 11 Missing ⚠️
internal/verify/uuid.go 69.69% 10 Missing ⚠️
internal/services/instance/servers_data_source.go 50.00% 5 Missing and 3 partials ⚠️
internal/verify/ip.go 66.66% 5 Missing ⚠️
internal/services/lb/types.go 55.55% 4 Missing ⚠️
internal/services/instance/server.go 85.00% 2 Missing and 1 partial ⚠️
internal/services/lb/testfuncs/checks.go 0.00% 3 Missing ⚠️
internal/services/k8s/helpers_k8s.go 50.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
- Coverage   71.43%   71.11%   -0.33%     
==========================================
  Files         277      335      +58     
  Lines       35875    33802    -2073     
==========================================
- Hits        25628    24037    -1591     
+ Misses       8028     7436     -592     
- Partials     2219     2329     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone marked this pull request as ready for review August 26, 2024 13:25
@Codelax Codelax added this pull request to the merge queue Aug 26, 2024
Merged via the queue into scaleway:master with commit 3c28869 Aug 26, 2024
43 checks passed
@remyleone remyleone deleted the staticcheck branch August 26, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Account issues, bugs and feature requests baremetal container Container issues, bugs and feature requests domain Domains issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests object Object storage issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw webhosting Webhosting issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants