Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): set project_id as optional in datasources #2738

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 13, 2024

Fix #2737

@Codelax Codelax added bug secret Managed Secret Manager issues, bugs and feature requests labels Sep 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (fe86049) to head (64e805d).
Report is 174 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/secret/helpers.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
- Coverage   71.43%   71.12%   -0.32%     
==========================================
  Files         277      336      +59     
  Lines       35875    33832    -2043     
==========================================
- Hits        25628    24063    -1565     
+ Misses       8028     7439     -589     
- Partials     2219     2330     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Sep 13, 2024
Merged via the queue into scaleway:master with commit 6d9ffa5 Sep 13, 2024
40 checks passed
@Codelax Codelax deleted the fix/secret-ds-optional-project-id branch September 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret_version datasource should not require a default project id
3 participants