Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(account_project): retry delete when project is not usable #2742

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 17, 2024

Closes #2426

@Codelax Codelax added bug account Account issues, bugs and feature requests labels Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (fe86049) to head (e8dfe27).
Report is 178 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/account/helpers.go 0.00% 7 Missing ⚠️
internal/services/account/project.go 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2742      +/-   ##
==========================================
- Coverage   71.43%   71.05%   -0.38%     
==========================================
  Files         277      337      +60     
  Lines       35875    34072    -1803     
==========================================
- Hits        25628    24211    -1417     
+ Misses       8028     7511     -517     
- Partials     2219     2350     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

remyleone
remyleone previously approved these changes Sep 17, 2024
@remyleone remyleone added this pull request to the merge queue Sep 17, 2024
Merged via the queue into scaleway:master with commit 8fb9c93 Sep 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Account issues, bugs and feature requests bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account_project: retry delete on 412
3 participants