Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instance): extract server volumes update #2743

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 17, 2024

Prepare for #2605

@Codelax Codelax added the instance Instance issues, bugs and feature requests label Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.19%. Comparing base (fe86049) to head (ac9c568).
Report is 181 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/instance/server.go 76.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   71.43%   71.19%   -0.25%     
==========================================
  Files         277      337      +60     
  Lines       35875    34137    -1738     
==========================================
- Hits        25628    24303    -1325     
+ Misses       8028     7484     -544     
- Partials     2219     2350     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the refactor/instance-server-update-volumes branch from 22d14e5 to b3b0ddc Compare September 17, 2024 13:36
@Codelax Codelax force-pushed the refactor/instance-server-update-volumes branch from b3b0ddc to ac9c568 Compare September 17, 2024 13:39
@remyleone remyleone added this pull request to the merge queue Sep 17, 2024
Merged via the queue into scaleway:master with commit 980722b Sep 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants