Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance_server): prevent usage of routed_ip_enabled as false #2763

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Oct 4, 2024

NAT IPs are coming to an end, users received emails to ask them to migrate. If not done manually, migration will be forced.
I'm changing the provider so it blocks users from using NAT IPs. Goal is to make them consider manually migrating before being forced.

If you previously used NAT IPs, you can remove the explicit field configuration (remove: routed_ip_enabled: false). If not set, the provider will be able to work after the migration. Otherwise the provider will block after migration as it will not be able to migrate back from nat to routed.

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Oct 4, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (fe86049) to head (d15f02b).
Report is 199 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/instance/server.go 0.00% 11 Missing ⚠️
internal/services/instance/ip.go 22.22% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2763      +/-   ##
==========================================
- Coverage   71.43%   71.12%   -0.32%     
==========================================
  Files         277      328      +51     
  Lines       35875    32916    -2959     
==========================================
- Hits        25628    23411    -2217     
+ Misses       8028     7254     -774     
- Partials     2219     2251      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Oct 8, 2024
Merged via the queue into scaleway:master with commit 36c4cac Oct 8, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants